Skip to content

Fix #3874: preserve escaped commas in snippet literals#4436

Merged
datho7561 merged 2 commits into
redhat-developer:mainfrom
MeherSru:fix-3874-local-variable-generics
Jul 8, 2026
Merged

Fix #3874: preserve escaped commas in snippet literals#4436
datho7561 merged 2 commits into
redhat-developer:mainfrom
MeherSru:fix-3874-local-variable-generics

Conversation

@MeherSru

@MeherSru MeherSru commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Fixes #3874

@MeherSru MeherSru marked this pull request as ready for review June 25, 2026 15:54

@wenytang-ms wenytang-ms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's better to add a unit test case.

@MeherSru

Copy link
Copy Markdown
Contributor Author

LGTM, it's better to add a unit test case.

Thanks for the suggestion! I've added a unit test and pushed the changes.

@datho7561 datho7561 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fixes the issue. Thanks, Meher!

@datho7561 datho7561 merged commit 1bf3877 into redhat-developer:main Jul 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create local variable quick fix is broken for types with multiple generic arguments.

3 participants